Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable ECAL reconstructions to use different time calibration records - 131x #42868

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Enable ECAL reconstructions to use different time calibration records - 131x #42868

merged 2 commits into from
Oct 4, 2023

Conversation

thomreis
Copy link
Contributor

PR description:

Adding two ESInputTag parameters to be able to select the record that the timing calibrations and timing offsets are taken from by the multifit algorithm and other ECAL time reconstructions.
This will be needed to support two records of those conditions within a GT.
Having two records in a GT will be required in some cases (e.g. MC GTs) because two different timing algorithms, using two different sets of conditions, run at the HLT and in offline reconstruction.

This PR just adds the capability to specify the record label but no changes to configuration are made and no changes in existing workflows are expected.

Changes to the multifit configuration may be required to enable the use of the second record on the GT for 13_1_X releases and will be done in a separate PR.

PR validation:

Passes limited matrix tests.

Backport of #42817 and #42860

This backport is needed to allow one GT to be used for HLT and offline reconstruction in 13_1_X MC.

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Sep 26, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 26, 2023 •
edited
Loading

A new Pull Request was created by @thomreis (Thomas Reis) for CMSSW_13_1_X.

It involves the following packages:

  • RecoLocalCalo/EcalRecProducers (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@youyingli, @apsallid, @rchatter, @argiro, @missirol, @thomreis, @wang0jin this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor Author

type ecal

@cmsbuild cmsbuild added the ecal label Sep 26, 2023
@thomreis
Copy link
Contributor Author

enable gpu

@thomreis
Copy link
Contributor Author

backport of #42860

@thomreis
Copy link
Contributor Author

please test

@mmusich
Copy link
Contributor

mmusich commented Sep 26, 2023

assign hlt

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@mmusich,@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-834bb8/34904/summary.html
COMMIT: 530255f
CMSSW: CMSSW_13_1_X_2023-09-26-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42868/34904/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3187455
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3187433
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 3
  • DQMHistoTests: Total histograms compared: 40086
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 40064
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 2 files compared)
  • Checked 8 log files, 6 edm output root files, 3 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Sep 27, 2023

unassign hlt

  • As discussed in a meeting between ECAL, TSG, Reco, AlCa, and PPD, the proponents will change the set of conditions such that the HLT will continue to consume the current record. Therefore hlt-signature is not needed.

@jfernan2
Copy link
Contributor

+1
Failed tests look unrelated, master version of this PR #42864 runs fine

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@antoniovilela
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 15594bf into cms-sw:CMSSW_13_1_X Oct 4, 2023
@thomreis thomreis deleted the ecal-timing-cond-selection-config-131x branch February 2, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok ecal fully-signed orp-approved reconstruction-approved tests-rejected
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
6 participants
@thomreis @cmsbuild @mmusich @jfernan2 @rappoccio @antoniovilela